Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette for check model #575

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Vignette for check model #575

wants to merge 13 commits into from

Conversation

strengejacke
Copy link
Member

@strengejacke strengejacke commented Apr 9, 2023

Fixes #395

@strengejacke
Copy link
Member Author

Maybe we can integrate with #574

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.50%. Comparing base (4d523a7) to head (24dd049).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   57.30%   57.50%   +0.19%     
==========================================
  Files          87       87              
  Lines        6416     6436      +20     
==========================================
+ Hits         3677     3701      +24     
+ Misses       2739     2735       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke
Copy link
Member Author

What is not quite clear to me is the demonstration of the relationship between p and pd? Your introduction ends with

Many of these assumptions can be checked using the check_model() function. We will demonstrate this function using the mtcars dataset.

The reader now knows why model diagnostic is important, why eye-balling is preferred over statistical tests, which kind of assumptions are important to test, and how to do this (using check_model()).

But then you start with simulations to show the relation between p and pd, and that interpreting p-values is not easy. Why this section? This is not directly related to model diagnostics (regarding show cases of check_model()).

@IndrajeetPatil IndrajeetPatil changed the title Vignette Vignette for check model Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for check_model()
3 participants